Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check pod readiness in ingress scale test #5774

Merged
merged 3 commits into from
Jun 18, 2024
Merged

check pod readiness in ingress scale test #5774

merged 3 commits into from
Jun 18, 2024

Conversation

vepatel
Copy link
Contributor

@vepatel vepatel commented Jun 18, 2024 •
edited
Loading

Proposed changes

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@vepatel vepatel requested a review from a team as a code owner June 18, 2024 12:18
@github-actions github-actions bot added python Pull requests that update Python code tests Pull requests that update tests labels Jun 18, 2024
@vepatel vepatel merged commit 8c79f27 into main Jun 18, 2024
54 of 81 checks passed
@vepatel vepatel deleted the tests/fix-ingress-scale branch June 18, 2024 14:23
ssrahul96 pushed a commit to ssrahul96/kubernetes-ingress that referenced this pull request Jun 20, 2024
@vepatel @ssrahul96
check pod readiness in ingress scale test (nginxinc#5774)
d5ae348
This was referenced Jul 1, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pdabelf5 pdabelf5 pdabelf5 approved these changes

@AlexFenlon AlexFenlon AlexFenlon approved these changes

@oseoin oseoin oseoin approved these changes

Assignees
No one assigned
Labels
python Pull requests that update Python code tests Pull requests that update tests
Projects
NGINX Ingress Controller
Status: Done 🚀
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vepatel @oseoin @AlexFenlon @pdabelf5