Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check for non 50x 404 response #5851

Merged
merged 2 commits into from
Jun 25, 2024
Merged

Check for non 50x 404 response #5851

merged 2 commits into from
Jun 25, 2024

Conversation

vepatel
Copy link
Contributor

@vepatel vepatel commented Jun 25, 2024 •
edited
Loading

Proposed changes

  • check for non 50x 404 response

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@vepatel vepatel requested review from oseoin and pdabelf5 June 25, 2024 11:18
@vepatel vepatel requested a review from a team as a code owner June 25, 2024 11:18
@github-actions github-actions bot added python Pull requests that update Python code tests Pull requests that update tests labels Jun 25, 2024
@vepatel vepatel enabled auto-merge (squash) June 25, 2024 11:46
@vepatel vepatel merged commit 18a7c12 into main Jun 25, 2024
80 checks passed
@vepatel vepatel deleted the tests/check-backend branch June 25, 2024 12:10
AlexFenlon pushed a commit that referenced this pull request Jul 1, 2024
@vepatel @AlexFenlon
check for non 50x 404 response (#5851)
4357b9b
@AlexFenlon AlexFenlon mentioned this pull request Jul 1, 2024
Closed
@pdabelf5 pdabelf5 removed the python Pull requests that update Python code label Sep 23, 2024
@pdabelf5 pdabelf5 changed the title check for non 50x 404 response Check for non 50x 404 response Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjngx jjngx jjngx approved these changes

@AlexFenlon AlexFenlon AlexFenlon approved these changes

@j1m-ryan j1m-ryan j1m-ryan approved these changes

@oseoin oseoin oseoin approved these changes

@pdabelf5 pdabelf5 Awaiting requested review from pdabelf5

Assignees
No one assigned
Labels
tests Pull requests that update tests
Projects
NGINX Ingress Controller
Status: Done 🚀
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@vepatel @oseoin @j1m-ryan @AlexFenlon @jjngx @pdabelf5