Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix daemonset template for helm #588

Merged
merged 1 commit into from
Jun 10, 2019
Merged

Fix daemonset template for helm #588

merged 1 commit into from
Jun 10, 2019

Conversation

Rulox
Copy link
Contributor

@Rulox Rulox commented Jun 10, 2019

Proposed changes

Bug introduced in: #581

DaemonSet helm template has a bug in the customPorts YAML indentation. It is 4 and it should be 8. This PR Fixes it.

@Rulox Rulox added the bug An issue reporting a potential bug label Jun 10, 2019
@Rulox Rulox requested review from pleshakov and tellet June 10, 2019 14:59
@Rulox Rulox self-assigned this Jun 10, 2019
tellet
tellet approved these changes Jun 10, 2019
View reviewed changes
Copy link
Contributor

@tellet tellet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@Rulox Rulox merged commit dc0aeee into master Jun 10, 2019
@pleshakov pleshakov deleted the fix-customports-daemonset branch June 18, 2019 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pleshakov pleshakov pleshakov approved these changes

@tellet tellet tellet approved these changes

Assignees

@Rulox Rulox

Labels
bug An issue reporting a potential bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Rulox @pleshakov @tellet