Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add fail-timeout and max-fails support to vs/vsr #607

Merged
merged 1 commit into from
Jul 2, 2019
Merged

Add fail-timeout and max-fails support to vs/vsr #607

merged 1 commit into from
Jul 2, 2019

Conversation

Rulox
Copy link
Contributor

@Rulox Rulox commented Jun 27, 2019

Proposed changes

fail-timeout and max-fails can be used in Upstreams in VirtualServer and VirtualServerRoutes resources.

Also changed the parseSlowStart function to make it more generic as ParseTime exportable function to validate all the times and timeouts of configuration.

@Rulox Rulox added the enhancement Pull requests for new features/feature enhancements label Jun 27, 2019
@Rulox Rulox self-assigned this Jun 27, 2019
pleshakov
pleshakov suggested changes Jun 27, 2019
View reviewed changes
Copy link
Contributor

@pleshakov pleshakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please see my comments

internal/configs/virtualserver.go Outdated Show resolved Hide resolved
pkg/apis/configuration/validation/validation.go Show resolved Hide resolved
pkg/apis/configuration/v1alpha1/types.go Outdated Show resolved Hide resolved
@Rulox Rulox requested a review from pleshakov June 28, 2019 10:37
@komapa
Copy link

komapa commented Jul 1, 2019

Hey folks, while you are all here, can we also add max_conns as a parameter to the upstreams? We were about to ask/open a PR about it but here seems like a very small lift to have it added. Thoughts?

@pleshakov
Copy link
Contributor

@komapa max_conns makes sense. We'll add it shortly. thx.

pleshakov
pleshakov approved these changes Jul 1, 2019
View reviewed changes
Copy link
Contributor

@pleshakov pleshakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
Please see some small changes requested.

pkg/apis/configuration/validation/validation.go Outdated Show resolved Hide resolved
pkg/apis/configuration/validation/validation_test.go Outdated Show resolved Hide resolved
pkg/apis/configuration/validation/validation.go Outdated Show resolved Hide resolved
@pleshakov
Copy link
Contributor

@Rulox lgtm

@Rulox Rulox merged commit eace1dd into master Jul 2, 2019
@Rulox Rulox deleted the passive-health-checks branch July 2, 2019 14:06
@Dean-Coakley
Copy link
Contributor

@komapa max_conns support was just added in #634

It is available now via the :edge tag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dean-Coakley Dean-Coakley Dean-Coakley approved these changes

@pleshakov pleshakov pleshakov approved these changes

Assignees

@Rulox Rulox

Labels
enhancement Pull requests for new features/feature enhancements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Rulox @komapa @pleshakov @Dean-Coakley