Add keepalive support to vs/vsr #617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dean-Coakley
added
the
enhancement
Rulox
suggested changes
Jul 8, 2019
pleshakov
suggested changes
Jul 8, 2019
There was a problem hiding this comment.
Please see my review.
Additionally, I suggest adding keepalive here https://github.com/nginxinc/kubernetes-ingress/blob/master/internal/configs/version2/templates_test.go#L8
Also, the changes in the plus template are missing. Note sure if that was intentional.
pleshakov
suggested changes
Jul 10, 2019
Rulox
approved these changes
Jul 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Support configuring keepalive connections in upstreams of VirtualServer/VirtualServerRoute.
Checklist
Before creating a PR, run through this checklist and mark each as complete.