Add retries support for vs/vsr #628
Conversation
There was a problem hiding this comment.
@LorcanMcVeigh thanks for the PR!
Please see my comments.
Additionally, we need to validate all fields in our resources. Make sure to add validation for the newly added fields. You can take a look at how other fields in the upstream are validated. next_upstream might be tricky - make sure to study carefully how it works http://nginx.org/en/docs/http/ngx_http_proxy_module.html#proxy_next_upstream As always, make sure you validation code works the same way as NGINX would validate those fields.
examples-of-custom-resources/basic-configuration/cafe-virtual-server.yaml
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
lgtm, 1 small suggestion. Also as Michael said, you need to add validation for the new fields. Check https://github.com/nginxinc/kubernetes-ingress/blob/master/pkg/apis/configuration/validation/validation.go#L124
LorcanMcVeigh
force-pushed
the
support-retries
branch
from
e17ed0c
to
742676a
Compare
LorcanMcVeigh
force-pushed
the
support-retries
branch
from
dacd4a7
to
9ebcc9b
Compare
There was a problem hiding this comment.
lgtm 
@LorcanMcVeigh remember to squash all your commits in one before merging.
Proposed changes
Added support and documentation for next-upstream-timeout and next-upstream-retries
Checklist
Before creating a PR, run through this checklist and mark each as complete.