-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable batch reload when batch finishes #6446
Conversation
✅ All required contributors have signed the F5 CLA for this PR. Thank you! |
I have hereby read the F5 CLA and agree to its terms |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6446 +/- ##
==========================================
- Coverage 53.24% 53.20% -0.04%
==========================================
Files 85 85
Lines 16015 16018 +3
==========================================
- Hits 8527 8523 -4
- Misses 7082 7087 +5
- Partials 406 408 +2 ☔ View full report in Codecov by Sentry. |
@dareste excellent! Since none of the existing tests failed, it's likely there is no coverage for the incorrect behaviour. Would you be able to add tests for the fix? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 let's think how to implement tests at the integration level.
Proposed changes
This change solves the issue described in #6445 by setting the batch reload flag to false when a batch process ends.
Checklist
Before creating a PR, run through this checklist and mark each as complete.