Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable batch reload when batch finishes #6446

Merged
merged 4 commits into from
Sep 23, 2024

Conversation

dareste
Copy link
Contributor

@dareste dareste commented Sep 17, 2024

Proposed changes

This change solves the issue described in #6445 by setting the batch reload flag to false when a batch process ends.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Copy link

github-actions bot commented Sep 17, 2024

✅ All required contributors have signed the F5 CLA for this PR. Thank you!
Posted by the CLA Assistant Lite bot.

@github-actions github-actions bot added the go Pull requests that update Go code label Sep 17, 2024
@dareste
Copy link
Contributor Author

dareste commented Sep 17, 2024

I have hereby read the F5 CLA and agree to its terms

Copy link

codecov bot commented Sep 17, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 53.20%. Comparing base (eba387b) to head (44a2f29).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
internal/k8s/controller.go 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6446      +/-   ##
==========================================
- Coverage   53.24%   53.20%   -0.04%     
==========================================
  Files          85       85              
  Lines       16015    16018       +3     
==========================================
- Hits         8527     8523       -4     
- Misses       7082     7087       +5     
- Partials      406      408       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dareste dareste marked this pull request as ready for review September 17, 2024 16:00
@dareste dareste requested a review from a team as a code owner September 17, 2024 16:00
@jjngx
Copy link
Contributor

jjngx commented Sep 17, 2024

@dareste excellent! Since none of the existing tests failed, it's likely there is no coverage for the incorrect behaviour. Would you be able to add tests for the fix?

Copy link
Contributor

@jjngx jjngx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 let's think how to implement tests at the integration level.

@j1m-ryan j1m-ryan merged commit ea8e46b into nginxinc:main Sep 23, 2024
84 of 101 checks passed
@pdabelf5 pdabelf5 added bug An issue reporting a potential bug and removed go Pull requests that update Go code labels Sep 23, 2024
@pdabelf5 pdabelf5 changed the title fix: disable batch reload when batch finishes Disable batch reload when batch finishes Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An issue reporting a potential bug
Projects
Status: Done 🚀
Development

Successfully merging this pull request may close these issues.

[Bug]: The batchSyncEnabled flag is not reverted back to false when batch processing ends
4 participants