Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NIC+WAFv5 tests #6456

Merged
merged 27 commits into from
Sep 23, 2024
Merged

Add NIC+WAFv5 tests #6456

merged 27 commits into from
Sep 23, 2024

Conversation

vepatel
Copy link
Contributor

@vepatel vepatel commented Sep 18, 2024

Proposed changes

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@github-actions github-actions bot added python Pull requests that update Python code tests Pull requests that update tests labels Sep 18, 2024
@github-actions github-actions bot added the chore Pull requests for routine tasks label Sep 19, 2024
@github-actions github-actions bot added the github_actions Pull requests that update Github_actions code label Sep 19, 2024
Copy link

codecov bot commented Sep 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.24%. Comparing base (66c2285) to head (47c2e88).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6456   +/-   ##
=======================================
  Coverage   53.24%   53.24%           
=======================================
  Files          85       85           
  Lines       16015    16015           
=======================================
  Hits         8527     8527           
  Misses       7082     7082           
  Partials      406      406           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot added the docker Pull requests that update Docker code label Sep 19, 2024
@vepatel vepatel marked this pull request as ready for review September 20, 2024 15:22
@vepatel vepatel requested a review from a team as a code owner September 20, 2024 15:22
@vepatel vepatel linked an issue Sep 20, 2024 that may be closed by this pull request
@vepatel vepatel merged commit 0ca75be into main Sep 23, 2024
30 checks passed
@vepatel vepatel deleted the tests/waf-v5 branch September 23, 2024 09:34
@pdabelf5 pdabelf5 changed the title add NIC+WAFv5 tests Add NIC+WAFv5 tests Sep 23, 2024
@pdabelf5 pdabelf5 removed python Pull requests that update Python code github_actions Pull requests that update Github_actions code docker Pull requests that update Docker code chore Pull requests for routine tasks labels Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Pull requests that update tests
Projects
Status: Done 🚀
Development

Successfully merging this pull request may close these issues.

Write python test for NIC+WAFv5 integration
3 participants