Add slow-start support in vs/vsr #655

bvighnesha · 2019-08-13T11:21:06Z

Proposed changes

Describe the use case and detail of the change. If this PR addresses an issue on GitHub, make sure to include a link to that issue here in this description (not in the title of the PR).

Checklist

Before creating a PR, run through this checklist and mark each as complete.

I have read the CONTRIBUTING doc
I have added tests that prove my fix is effective or that my feature works
I have checked that all unit tests pass after adding my changes
I have updated necessary documentation
I have rebased my branch onto master
I will ensure my PR is targeting the master branch and pulling from my branch from my own fork

Rulox

Hey @b-v-r thanks for the PR!

I've found 2 small issues and made some suggestion to fix them. Let me know what you think

Rulox · 2019-08-14T15:32:18Z

internal/configs/virtualserver.go

@@ -342,6 +347,12 @@ func generateUpstream(upstreamName string, upstream conf_v1alpha1.Upstream, isEx
 			FailTimeout: generateString(upstream.FailTimeout, cfgParams.FailTimeout),
 			MaxConns:    generateIntFromPointer(upstream.MaxConns, cfgParams.MaxConns),
 			Resolve:     isExternalNameSvc,
+			SlowStart:   upstream.SlowStart,
+		}
+		if incompatibleLBMethods[upstream.LBMethod] {


If upstream.LBMethod is not defined, the cfgParams.LBMethod will be used (check line 363 of this file: generateLBMethod(upstream.LBMethod, cfgParams.LBMethod),). That's why using the upstream.LBMethod here is not the good option.

I suggest create a variable lbMethod = generateLBMethod(upstream.LBMethod, cfgParams.LBMethod), and use that variable here incompatibleLBMethods[lbMethod] and in line 363.

Apart from that, I would move this check outside the for loop. All the servers for the upstream will work the same way. This way we only do the check once, and also we can create a variable for slowStart and make everything more explicit (instead of changing the s.SlowStart afterwards)

I mean this:

incompatibleLBMethods := map[string]bool{ "random": true, "ip-hash": true, "hash": true, } lbMethod := generateLBMethod(upstream.LBMethod, cfgParams.LBMethod) slowStart := upstream.SlowStart if upstream.SlowStart != "" && incompatibleLBMethods[lbMethod] { // do the warning slowStart = "" } for _, e := range endpoints { s := version2.UpstreamServer{ Address: e, MaxFails: generateIntFromPointer(upstream.MaxFails, cfgParams.MaxFails), FailTimeout: generateString(upstream.FailTimeout, cfgParams.FailTimeout), MaxConns: generateIntFromPointer(upstream.MaxConns, cfgParams.MaxConns), Resolve: isExternalNameSvc, SlowStart: slowStart, } upsServers = append(upsServers, s) } return version2.Upstream{ Name: upstreamName, Servers: upsServers, LBMethod: lbMethod, Keepalive: generateIntFromPointer(upstream.Keepalive, cfgParams.Keepalive), }

Let me know your thoughts!
PS: Code is not tested, just to point the idea.

I would further suggest putting the logic for checking for incompatible method in a separate function and writing a unit test for that function.

lbMethod := generateLBMethod(upstream.LBMethod, cfgParams.LBMethod) slowStart := for _, e := range endpoints { s := version2.UpstreamServer{ Address: e, MaxFails: generateIntFromPointer(upstream.MaxFails, cfgParams.MaxFails), FailTimeout: generateString(upstream.FailTimeout, cfgParams.FailTimeout), MaxConns: generateIntFromPointer(upstream.MaxConns, cfgParams.MaxConns), Resolve: isExternalNameSvc, SlowStart: generateSlowStart(lbMethod, upstream.SlowStart, isPlus) , } upsServers = append(upsServers, s) } return version2.Upstream{ Name: upstreamName, Servers: upsServers, LBMethod: lbMethod, Keepalive: generateIntFromPointer(upstream.Keepalive, cfgParams.Keepalive), }

Note that isPlus will have to be added to the list of generateUpstream arguments. We need it because slow start only works for NGINX Plus.

Additionally, also note that hash method is defined by hash + some varialble(s), for example $hash $request_id. As a result, the check incompatibleLBMethods[lbMethod] for hash method won't work. We need to check for the prefix, not the exact match here. Please also see the implementation of ParseLBMethod function https://github.com/nginxinc/kubernetes-ingress/blob/master/internal/configs/parsing_helpers.go#L92

Also, I suggest renaming incompatibleLBMethods to incompatibleLBMethodsForSlowStart and making it a global variable similar to https://github.com/nginxinc/kubernetes-ingress/blob/master/internal/configs/parsing_helpers.go#L119 so that the map is only created once.

Rulox · 2019-08-14T15:36:56Z

internal/configs/virtualserver.go

+		}
+		if incompatibleLBMethods[upstream.LBMethod] {
+			//TODO trigger warning
+			glog.Warningf("The parameter slow-start cannot be used along with %s, load balancing method", upstream.LBMethod)


I think we can add also, at the end of the message, something like: "slow-start will be disabled for the Upstream %v", Upstream.Name, to make sure the user understands that slow-start is not working even if they set it due to conflicts. What do you think?

Also, the warning doesn't make sense when SlowStart == "", so we should check that (eg, if slowStart = "" it means the user didn't set it, so there's no point of checking and warning the user)

PS: @pleshakov I think is better if we use a warning for now, because emitting events from virtualserver.go can be tricky. Maybe we can do that in a future PR? Revisiting the warnings/errors and make sure to update them to Events when necessary?

@Rulox warningf for now works OK. we can add a PR later to support emitting events for warnings.

pleshakov

@b-v-r please see my comments.

Additionally, I suggest renaming the commit message and PR name to Add slow-start support in vs/vsr so that it reflects that we're adding the slow-start support to our VirtualServer/VirtualServerRoutes resources. This will also be consistent with the previous similar commits https://github.com/nginxinc/kubernetes-ingress/commits/master

pleshakov · 2019-08-14T18:52:12Z

docs/virtualserver-and-virtualserverroute.md

@@ -212,6 +212,7 @@ tls:
 | `next-upstream-tries` | The number of possible tries for passing a request to the next upstream server. See the [proxy_next_upstream_tries](http://nginx.org/en/docs/http/ngx_http_proxy_module.html#proxy_next_upstream_tries) directive. The `0` value turns off this limit. The default is `0`. | `int` | No |
 | `tls` | The TLS configuration for the Upstream. | [`tls`](#UpstreamTLS) | No |
 | `healthCheck` | The health check configuration for the Upstream. See the [health_check](http://nginx.org/en/docs/http/ngx_http_upstream_hc_module.html#health_check) directive. Note: this feature is supported only in NGINX Plus. | [`healthcheck`](#UpstreamHealthcheck) | No |
+| `slow-start` | The slow‑start allows an upstream server to gradually recover its weight from 0 to its nominal value after it has been recovered or became available or when the server becomes available after a period of time it was considered unavailable. Default value is zero seconds ("0s"), i.e. slow start is disabled. See the [slow-start](https://nginx.org/en/docs/http/ngx_http_upstream_module.html#slow_start) parameter of the server directive. Note: The parameter cannot be used along with the hash and ip_hash load balancing methods. | `string` | No |


Suggested change

| `slow-start` | The slow‑start allows an upstream server to gradually recover its weight from 0 to its nominal value after it has been recovered or became available or when the server becomes available after a period of time it was considered unavailable. Default value is zero seconds ("0s"), i.e. slow start is disabled. See the [slow-start](https://nginx.org/en/docs/http/ngx_http_upstream_module.html#slow_start) parameter of the server directive. Note: The parameter cannot be used along with the hash and ip_hash load balancing methods. | `string` | No |

| `slow-start` | The slow start allows an upstream server to gradually recover its weight from 0 to its nominal value after it has been recovered or became available or when the server becomes available after a period of time it was considered unavailable. By default, the slow start is disabled. See the [slow_start](https://nginx.org/en/docs/http/ngx_http_upstream_module.html#slow_start) parameter of the server directive. Note: The parameter cannot be used along with the `random`, `hash` or `ip_hash` load balancing methods and will be ignored. | `string` | No |

pleshakov · 2019-08-14T18:55:03Z

internal/configs/version2/nginx-plus.virtualserver.tmpl

@@ -5,7 +5,7 @@ upstream {{ $u.Name }} {
    {{ if $u.LBMethod }}{{ $u.LBMethod }};{{ end }}

    {{ range $s := $u.Servers }}
-    server {{ $s.Address }} max_fails={{ $s.MaxFails }} fail_timeout={{ $s.FailTimeout }} max_conns={{ $s.MaxConns }}{{ if $s.Resolve }} resolve{{ end }};
+    server {{ $s.Address }} max_fails={{ $s.MaxFails }} fail_timeout={{ $s.FailTimeout }}{{if $s.SlowStart }} slow_start={{ $s.SlowStart }}{{end}} max_conns={{ $s.MaxConns }}{{ if $s.Resolve }} resolve{{ end }};


We need to use the curly brackets in a consistent manner.

Suggested change

server {{ $s.Address }} max_fails={{ $s.MaxFails }} fail_timeout={{ $s.FailTimeout }}{{if $s.SlowStart }} slow_start={{ $s.SlowStart }}{{end}} max_conns={{ $s.MaxConns }}{{ if $s.Resolve }} resolve{{ end }};

server {{ $s.Address }} max_fails={{ $s.MaxFails }} fail_timeout={{ $s.FailTimeout }}{{ if $s.SlowStart }} slow_start={{ $s.SlowStart }}{{ end }} max_conns={{ $s.MaxConns }}{{ if $s.Resolve }} resolve{{ end }};

pleshakov · 2019-08-14T19:03:27Z

internal/configs/virtualserver_test.go

@@ -238,7 +238,7 @@ func TestGenerateVirtualServerConfig(t *testing.T) {
 				Name: "vs_default_cafe_tea",


please fix the formatting in this file using gofmt.

pleshakov · 2019-08-14T19:12:13Z

internal/configs/virtualserver.go

@@ -342,6 +347,12 @@ func generateUpstream(upstreamName string, upstream conf_v1alpha1.Upstream, isEx
 			FailTimeout: generateString(upstream.FailTimeout, cfgParams.FailTimeout),
 			MaxConns:    generateIntFromPointer(upstream.MaxConns, cfgParams.MaxConns),
 			Resolve:     isExternalNameSvc,
+			SlowStart:   upstream.SlowStart,
+		}
+		if incompatibleLBMethods[upstream.LBMethod] {


I would further suggest putting the logic for checking for incompatible method in a separate function and writing a unit test for that function.

lbMethod := generateLBMethod(upstream.LBMethod, cfgParams.LBMethod) slowStart := for _, e := range endpoints { s := version2.UpstreamServer{ Address: e, MaxFails: generateIntFromPointer(upstream.MaxFails, cfgParams.MaxFails), FailTimeout: generateString(upstream.FailTimeout, cfgParams.FailTimeout), MaxConns: generateIntFromPointer(upstream.MaxConns, cfgParams.MaxConns), Resolve: isExternalNameSvc, SlowStart: generateSlowStart(lbMethod, upstream.SlowStart, isPlus) , } upsServers = append(upsServers, s) } return version2.Upstream{ Name: upstreamName, Servers: upsServers, LBMethod: lbMethod, Keepalive: generateIntFromPointer(upstream.Keepalive, cfgParams.Keepalive), }

Note that isPlus will have to be added to the list of generateUpstream arguments. We need it because slow start only works for NGINX Plus.

Additionally, also note that hash method is defined by hash + some varialble(s), for example $hash $request_id. As a result, the check incompatibleLBMethods[lbMethod] for hash method won't work. We need to check for the prefix, not the exact match here. Please also see the implementation of ParseLBMethod function https://github.com/nginxinc/kubernetes-ingress/blob/master/internal/configs/parsing_helpers.go#L92

Also, I suggest renaming incompatibleLBMethods to incompatibleLBMethodsForSlowStart and making it a global variable similar to https://github.com/nginxinc/kubernetes-ingress/blob/master/internal/configs/parsing_helpers.go#L119 so that the map is only created once.

pleshakov · 2019-08-14T19:13:50Z

internal/configs/virtualserver.go

+		}
+		if incompatibleLBMethods[upstream.LBMethod] {
+			//TODO trigger warning
+			glog.Warningf("The parameter slow-start cannot be used along with %s, load balancing method", upstream.LBMethod)


@Rulox warningf for now works OK. we can add a PR later to support emitting events for warnings.

pleshakov · 2019-08-14T19:15:10Z

pkg/apis/configuration/v1alpha1/types.go

@@ -41,6 +41,7 @@ type Upstream struct {
 	ProxyNextUpstreamTries   int          `json:"next-upstream-tries"`
 	TLS                      UpstreamTLS  `json:"tls"`
 	HealthCheck              *HealthCheck `json:"healthCheck"`
+	SlowStart                string       `json:"slow-start,omitempty"`


omitempty is not necessary here

pleshakov

Please see my comments.

Additionally, multiple files are not properly formatted. Make sure the code is formatted using gofmt tool. You can also configure your editor to do that when saving a file.

docs/virtualserver-and-virtualserverroute.md

pleshakov · 2019-08-20T00:17:58Z

internal/configs/virtualserver.go

 	var upsServers []version2.UpstreamServer
+	lbMethod := generateLBMethod(upstream.LBMethod, cfgParams.LBMethod)
+	slowStart := generateSlowStartForPlus(upstream, lbMethod)


instead of

if isPlus { s.SlowStart = slowStart }

I suggest to do the following:

slowStart := "" if isPlus { slowStart := generateSlowStartForPlus(upstream, lbMethod) }

this way generateSlowStartForPlus will only be invoked for Plus.

pleshakov · 2019-08-20T00:19:16Z

internal/configs/virtualserver.go

@@ -354,6 +366,23 @@ func generateUpstream(upstreamName string, upstream conf_v1alpha1.Upstream, isEx
 	}
 }

+func generateSlowStartForPlus(upstream conf_v1alpha1.Upstream, lbMethod string) string {
+


the empty line is not necessary

this wasn't addressed. we don't put empty lines at the beginning of the function

the empty line is back :) please remove

pleshakov · 2019-08-20T00:45:59Z

internal/configs/virtualserver.go

@@ -354,6 +366,23 @@ func generateUpstream(upstreamName string, upstream conf_v1alpha1.Upstream, isEx
 	}
 }

+func generateSlowStartForPlus(upstream conf_v1alpha1.Upstream, lbMethod string) string {


this function needs to be rewritten as it doesn't implement the slow start logic completely. The logic is below:

if slowStart is "" , return ""

if the lbMethod is either random, ip_hash or hash, print a warning and return "" . Note that the hash method is defined as hash + some varialble(s), for example $hash $request_id. The current implementation incorrectly allows methods like $hash $request_id. Also, the random method is similar to the hash, but has a finite number of possible values. Please see them here -- https://github.com/nginxinc/kubernetes-ingress/blob/master/internal/configs/parsing_helpers.go#L122-L126 Those should be excluded as well.

return slowStart

Also, the corresponding unit test must be rewritten as well. For the test, consider the following test cases:

Positive cases:

slow start is "" and the method is "least_conn", expects ""

slow_start is "10s" and the method is "least_conn", expects "10s"

Negative cases:

slow_start is "10s" and the method is "hash $something", expects ""

slow_start is "10s" and the method is "ip_hash", expects ""

slow_start is "10s" and the method is "random", expects "". Note, this can be repeated for all allowed variations of the random method -- https://github.com/nginxinc/kubernetes-ingress/blob/master/internal/configs/parsing_helpers.go#L122-L126

Please add any additional cases if necessary.

It looks better now! Great job. I am not 100% sure about the incompatibleLBMethodsForSlowStart so let's wait til @pleshakov has another look 🤔

Normally we have a preference for using a map like: https://github.com/nginxinc/kubernetes-ingress/blob/master/pkg/apis/configuration/validation/validation.go#L343-L357 which I think should be possible.

If sticking with a slice is necessary, you should be able to make it const , right?

Rulox

Looks good. 👍

Just small comments in the TestCases only for consistency. Overall looks good, waiting on @pleshakov final review too as I wasn't sure of 1 thing.

Rulox · 2019-08-20T11:42:35Z

internal/configs/virtualserver_test.go

@@ -1960,3 +1961,51 @@ func TestGenerateEndpointsForUpstream(t *testing.T) {
 		}
 	}
 }
+
+func TestGenerateSlowStartForPlus(t *testing.T) {


TestGenerateSlowStartForPlus doesn't follow the rest of the file consistency.

Why do we need the { } blocks delimiters? I think they are redundant

If there are more than 1 test case, normally we define the test cases in a slice of structs tests := []struct {...} and iterate over them. For instance, we could have 2 different Test functions. 1 for the incompatible methods and another one for compatible ones. That way you can still use the for loop in one of the functions (iterating over incompatibleLBMethodsForSlowStart) and another function using a []struct {...} for the other 2 cases with valid lbMethods, to keep consistency with the rest of the file.

Comments with all the cases are not needed as code should be auto explained (unless there's a weird edge case there)

Let me know if this makes sense to you and your thoughts!

Rulox · 2019-08-20T11:43:09Z

internal/configs/virtualserver.go

+
+	for _, nLBMethod := range incompatibleLBMethodsForSlowStart {
+		if strings.Contains(lbMethod, nLBMethod) {
+			//TODO trigger warning


The //TODO comment is not needed. I think we should avoid things like TODO or FIXME when merging to master.

Rulox · 2019-08-20T11:44:20Z

internal/configs/virtualserver.go

@@ -354,6 +366,23 @@ func generateUpstream(upstreamName string, upstream conf_v1alpha1.Upstream, isEx
 	}
 }

+func generateSlowStartForPlus(upstream conf_v1alpha1.Upstream, lbMethod string) string {


It looks better now! Great job. I am not 100% sure about the incompatibleLBMethodsForSlowStart so let's wait til @pleshakov has another look 🤔

Dean-Coakley

Looks pretty good. Just some code style to fix from @Rulox and my feedback and I'll approve.

Dean-Coakley · 2019-08-20T13:34:04Z

internal/configs/virtualserver.go

@@ -354,6 +366,23 @@ func generateUpstream(upstreamName string, upstream conf_v1alpha1.Upstream, isEx
 	}
 }

+func generateSlowStartForPlus(upstream conf_v1alpha1.Upstream, lbMethod string) string {


Normally we have a preference for using a map like: https://github.com/nginxinc/kubernetes-ingress/blob/master/pkg/apis/configuration/validation/validation.go#L343-L357 which I think should be possible.

If sticking with a slice is necessary, you should be able to make it const , right?

pleshakov

Please see my suggestions +1 to @Rulox and @Dean-Coakley 's comments

pleshakov · 2019-08-20T18:45:17Z

internal/configs/virtualserver.go

+		return ""
+	}
+
+	for _, nLBMethod := range incompatibleLBMethodsForSlowStart {


to check for the incompatible method, I suggest using approach similar to https://github.com/nginxinc/kubernetes-ingress/blob/master/internal/configs/parsing_helpers.go#L141-L148 :

first check if the method starts with hash

check if the method is in the map. This will require changing incompatibleLBMethodsForSlowStart to a map.

Dean-Coakley

Looks good to me!

Dean-Coakley · 2019-08-21T10:59:37Z

internal/configs/virtualserver_test.go

@@ -1960,3 +1961,44 @@ func TestGenerateEndpointsForUpstream(t *testing.T) {
 		}
 	}
 }
+
+func TestGenerateSlowStartForPlusWithInCompatibleLBMethods(t *testing.T) {
+	name := "test-slowstart-with-incompatible-LBMethods"


Completely optional: but personally I'd name this var serviceName or change the value to include the suffix -svc

At first glance I thought this was a name of a test case.

(Same applies to TestGenerateSlowStartForPlus)

pleshakov

@b-v-r thanks for the updates. Please see my comments

pleshakov · 2019-08-22T00:57:31Z

internal/configs/virtualserver.go

+	if slowStart == "" {
+		return ""
+	}
+	method := strings.TrimSpace(lbMethod)


there is no need for TrimSpace, as lbMethod in this function has already been parsed.

pleshakov · 2019-08-22T00:58:44Z

internal/configs/virtualserver.go

+	}
+	method := strings.TrimSpace(lbMethod)
+	if strings.HasPrefix(method, "hash") {
+		method = "hash"


for readability and clarity, it is better to return "" and print a warning in this block right way, rather than assigning it to the method variable.

pleshakov · 2019-08-22T00:59:13Z

internal/configs/virtualserver.go

@@ -14,6 +14,16 @@ import (

 const nginx502Server = "unix:/var/run/nginx-502-server.sock"

+var incompatibleLBMethodsForSlowStart = map[string]bool{
+	"random":                          true,
+	"ip-hash":                         true,


the correct method is ip_hash

pleshakov · 2019-08-22T01:03:52Z

internal/configs/virtualserver_test.go

+	}
+
+	for _, test := range tests {
+		lbMethod := generateLBMethod(test.upstream.LBMethod, "least_conn")


there is no need to call generateLBMethod. I suggest making the method the third field of the struct you use in tests array.

pleshakov · 2019-08-22T01:06:16Z

internal/configs/virtualserver_test.go

+	upstream := conf_v1alpha1.Upstream{Service: name, Port: 80, SlowStart: "10s"}
+	expected := ""
+
+	for lbMethod, _ := range incompatibleLBMethodsForSlowStart {


it is better to have an array of the input parameters like you have in the TestGenerateSlowStartForPlus. this will make the tests much more readable.

pleshakov · 2019-08-22T01:06:52Z

internal/configs/virtualserver_test.go

+	expected := ""
+
+	for lbMethod, _ := range incompatibleLBMethodsForSlowStart {
+		nlbMethod := generateLBMethod(upstream.LBMethod, lbMethod)


there is no need to call generateLBMethod. this is the same comment as for line 1998.

pleshakov

@b-v-r thanks for the changes. looks like we're almost there. please see my suggestions.

pleshakov · 2019-08-23T00:35:32Z

internal/configs/virtualserver.go

+var incompatibleLBMethodsForSlowStart = map[string]bool{
+	"random":                          true,
+	"ip_hash":                         true,
+	"hash":                            true,


hash is not required here, considering this change https://github.com/nginxinc/kubernetes-ingress/pull/655/files#diff-d8f2204ffe0ef11d167489c09e9f4170R380

pleshakov · 2019-08-23T00:37:13Z

internal/configs/virtualserver_test.go

+	}
+
+	for _, test := range tests {
+		for lbMethod, _ := range incompatibleLBMethodsForSlowStart {


this suggestion wasn't implemented #655 (comment) please have a list of input parameters rather than taking lb methods from incompatibleLBMethodsForSlowStart

pleshakov · 2019-08-23T00:41:53Z

internal/configs/virtualserver.go

 		Keepalive: generateIntFromPointer(upstream.Keepalive, cfgParams.Keepalive),
 	}
 }

+func generateSlowStartForPlus(upstream conf_v1alpha1.Upstream, lbMethod string) string {
+	slowStart := upstream.SlowStart


we don't usually create auxiliary variables like this one. Note that is only used twice. Can we just use upstream.SlowStart instead?

bvighnesha · 2019-08-25T02:51:01Z

@pleshakov can you please review changes

pleshakov

@b-v-r please see the comments about the new changes

internal/configs/virtualserver_test.go

pleshakov · 2019-08-26T23:14:21Z

internal/configs/virtualserver.go

@@ -354,6 +366,23 @@ func generateUpstream(upstreamName string, upstream conf_v1alpha1.Upstream, isEx
 	}
 }

+func generateSlowStartForPlus(upstream conf_v1alpha1.Upstream, lbMethod string) string {
+


the empty line is back :) please remove

internal/configs/virtualserver_test.go

Rulox

lgtm 🚀

bvighnesha requested a review from pleshakov August 13, 2019 11:21

bvighnesha self-assigned this Aug 13, 2019

bvighnesha requested a review from Rulox August 13, 2019 11:21

bvighnesha force-pushed the feature/support_slow_start_in_Plus branch 3 times, most recently from 3a004c1 to c15e1a4 Compare August 14, 2019 14:35

Rulox suggested changes Aug 14, 2019

View reviewed changes

pleshakov suggested changes Aug 14, 2019

View reviewed changes

bvighnesha force-pushed the feature/support_slow_start_in_Plus branch from c15e1a4 to 29e22eb Compare August 19, 2019 05:12

bvighnesha changed the title ~~Add slow-start in plus~~ feature/support_slow_start_in_Plus Aug 19, 2019

bvighnesha changed the title ~~feature/support_slow_start_in_Plus~~ support_slow_start_in_Plus Aug 19, 2019

bvighnesha force-pushed the feature/support_slow_start_in_Plus branch from 29e22eb to ce8439c Compare August 19, 2019 05:20

bvighnesha requested review from pleshakov and Rulox August 19, 2019 06:12

bvighnesha changed the title ~~support_slow_start_in_Plus~~ dd slow-start support in vs/vsr Aug 19, 2019

bvighnesha changed the title ~~dd slow-start support in vs/vsr~~ Add slow-start support in vs/vsr Aug 19, 2019

bvighnesha force-pushed the feature/support_slow_start_in_Plus branch from ce8439c to 849b35c Compare August 19, 2019 06:26

pleshakov suggested changes Aug 20, 2019

View reviewed changes

bvighnesha force-pushed the feature/support_slow_start_in_Plus branch from f42d1d3 to 59707e9 Compare August 20, 2019 05:21

bvighnesha requested review from pleshakov, Dean-Coakley and martialonline August 20, 2019 06:54

Rulox suggested changes Aug 20, 2019

View reviewed changes

Dean-Coakley reviewed Aug 20, 2019

View reviewed changes

pleshakov suggested changes Aug 20, 2019

View reviewed changes

bvighnesha requested review from Rulox, Dean-Coakley and pleshakov August 21, 2019 05:32

bvighnesha force-pushed the feature/support_slow_start_in_Plus branch from d229a0b to 353ecca Compare August 21, 2019 05:38

Dean-Coakley approved these changes Aug 21, 2019

View reviewed changes

pleshakov suggested changes Aug 22, 2019

View reviewed changes

bvighnesha requested review from pleshakov and Dean-Coakley August 22, 2019 03:11

bvighnesha force-pushed the feature/support_slow_start_in_Plus branch 2 times, most recently from cb5cc3d to 8423006 Compare August 22, 2019 03:21

bvighnesha requested a review from ampant August 22, 2019 04:02

pleshakov suggested changes Aug 23, 2019

View reviewed changes

ampant requested a review from pleshakov August 23, 2019 21:02

bvighnesha force-pushed the feature/support_slow_start_in_Plus branch from 8423006 to 6e18d66 Compare August 25, 2019 02:28

pleshakov suggested changes Aug 26, 2019

View reviewed changes

Dean-Coakley approved these changes Aug 27, 2019

View reviewed changes

pleshakov added the enhancement Pull requests for new features/feature enhancements label Aug 27, 2019

pleshakov approved these changes Aug 27, 2019

View reviewed changes

Add slow-start support in vs/vsr

facb764

bvighnesha force-pushed the feature/support_slow_start_in_Plus branch from 4546260 to facb764 Compare August 28, 2019 03:41

Rulox approved these changes Aug 28, 2019

View reviewed changes

bvighnesha merged commit 924726b into master Aug 28, 2019

Rulox deleted the feature/support_slow_start_in_Plus branch September 18, 2019 11:44

	server {{ $s.Address }} max_fails={{ $s.MaxFails }} fail_timeout={{ $s.FailTimeout }}{{if $s.SlowStart }} slow_start={{ $s.SlowStart }}{{end}} max_conns={{ $s.MaxConns }}{{ if $s.Resolve }} resolve{{ end }};
	server {{ $s.Address }} max_fails={{ $s.MaxFails }} fail_timeout={{ $s.FailTimeout }}{{ if $s.SlowStart }} slow_start={{ $s.SlowStart }}{{ end }} max_conns={{ $s.MaxConns }}{{ if $s.Resolve }} resolve{{ end }};

		@@ -238,7 +238,7 @@ func TestGenerateVirtualServerConfig(t *testing.T) {
		Name: "vs_default_cafe_tea",

Add slow-start support in vs/vsr #655

Add slow-start support in vs/vsr #655

Conversation

bvighnesha commented Aug 13, 2019 • edited by pleshakov Loading

Proposed changes

Checklist

Rulox left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pleshakov left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pleshakov left a comment • edited by Dean-Coakley Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Rulox left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Dean-Coakley left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pleshakov left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Dean-Coakley left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pleshakov left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pleshakov left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bvighnesha commented Aug 25, 2019

pleshakov left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Rulox left a comment

Choose a reason for hiding this comment

bvighnesha commented Aug 13, 2019 •

edited by pleshakov

Loading

pleshakov left a comment •

edited by Dean-Coakley

Loading