Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update helm schema examples #6666

Merged
merged 1 commit into from
Oct 15, 2024
Merged

Update helm schema examples #6666

merged 1 commit into from
Oct 15, 2024

Conversation

nginx-bot
Copy link
Contributor

Proposed changes

The examples in the helm schema file were out of date. These examples are used as documentation when using the AWS Marketplace add-on so need to be kept updated.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@nginx-bot nginx-bot requested a review from a team as a code owner October 15, 2024 15:29
@nginx-bot nginx-bot added the needs cherry pick Cherry pick this PR into a release branch label Oct 15, 2024
@github-actions github-actions bot added the helm_chart Pull requests that update the Helm Chart label Oct 15, 2024
@AlexFenlon AlexFenlon enabled auto-merge (squash) October 15, 2024 15:42
@AlexFenlon AlexFenlon merged commit b023cd0 into release-3.7 Oct 15, 2024
70 checks passed
@AlexFenlon AlexFenlon deleted the cherry-pick-release-3.7-3df7cc621074f3675efd2b0f18c2892ef329d6c2 branch October 15, 2024 15:53
@pdabelf5 pdabelf5 changed the title [cherry-pick] update helm schema examples Update helm schema examples Nov 6, 2024
@pdabelf5 pdabelf5 added chore Pull requests for routine tasks and removed helm_chart Pull requests that update the Helm Chart needs cherry pick Cherry pick this PR into a release branch labels Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjngx jjngx jjngx approved these changes

@AlexFenlon AlexFenlon AlexFenlon approved these changes

Assignees
No one assigned
Labels
chore Pull requests for routine tasks
Projects
NGINX Ingress Controller
Status: Done 🚀
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nginx-bot @AlexFenlon @jjngx @pdabelf5