Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for configuring pxoxy-buffer-settings #68

Merged
merged 1 commit into from
Nov 16, 2016

Conversation

df-mreidel
Copy link

A small patch to enable configuring proxy_buffers and proxy_buffer_size which is necessary especially when your backends send a lot of headers and you want to increase the default value.

@pleshakov
Copy link
Contributor

pleshakov commented Nov 15, 2016

@df-mreidel
Thanks for the pull request!

I have few suggestions:

  • Since buffering requirements can differ from an application to an application, it's better to make them configurable per Ingress resource, similar to what we have for the proxy_read_timeout directive.
  • There are a couple of others important buffering-releated NGINX directives:

@df-mreidel
Copy link
Author

I can make these settings configurable per resource, no problem. I'll take care of the other 2 settings as well as soon as I'm back to work. Thanks for looking over it!

@df-mreidel
Copy link
Author

Okay, made it location-aware and added your suggestions. Already tested and working.

@pleshakov
Copy link
Contributor

@df-mreidel
Awesome! thx!

@pleshakov pleshakov merged commit 8b32eef into nginxinc:master Nov 16, 2016
@df-mreidel df-mreidel deleted the proxy-buffers branch November 16, 2016 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants