Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check if config map created for leader-election #686

Merged
merged 4 commits into from
Sep 13, 2019
Merged

Check if config map created for leader-election #686

merged 4 commits into from
Sep 13, 2019

Conversation

LorcanMcVeigh
Copy link
Contributor

Proposed changes

If the cli argument value is not a valid value for a resource name and/or if the IC can't create a config map, the IC exits with an error

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto master
  • I will ensure my PR is targeting the master branch and pulling from my branch from my own fork

@LorcanMcVeigh LorcanMcVeigh self-assigned this Sep 9, 2019
ampant
ampant approved these changes Sep 11, 2019
View reviewed changes
Copy link
Contributor

@ampant ampant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Dean-Coakley
Dean-Coakley reviewed Sep 11, 2019
View reviewed changes
cmd/nginx-ingress/main.go Outdated Show resolved Hide resolved
cmd/nginx-ingress/main.go Outdated Show resolved Hide resolved
pkg/apis/configuration/validation/validation.go Outdated Show resolved Hide resolved
Rulox
Rulox suggested changes Sep 11, 2019
View reviewed changes
Copy link
Contributor

@Rulox Rulox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, 1 small suggestion, let me know if it makes sense.

cmd/nginx-ingress/main.go Outdated Show resolved Hide resolved
Dean-Coakley
Dean-Coakley approved these changes Sep 12, 2019
View reviewed changes
Copy link
Contributor

@Dean-Coakley Dean-Coakley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

cmd/nginx-ingress/main.go Outdated Show resolved Hide resolved
Rulox
Rulox approved these changes Sep 13, 2019
View reviewed changes
Copy link
Contributor

@Rulox Rulox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@LorcanMcVeigh LorcanMcVeigh merged commit a560a15 into master Sep 13, 2019
@LorcanMcVeigh LorcanMcVeigh deleted the custom-leader-election branch September 13, 2019 10:51
@pleshakov pleshakov changed the title Check if config map created with leader-election Check if config map created for leader-election Dec 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ampant ampant ampant approved these changes

@Dean-Coakley Dean-Coakley Dean-Coakley approved these changes

@Rulox Rulox Rulox approved these changes

@pleshakov pleshakov Awaiting requested review from pleshakov

@bvighnesha bvighnesha Awaiting requested review from bvighnesha

Assignees

@LorcanMcVeigh LorcanMcVeigh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@LorcanMcVeigh @Rulox @Dean-Coakley @ampant