Add ServerStatusZones support in vs/vsr #693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dean-Coakley
added
the
enhancement
Dean-Coakley
force-pushed
the
vs-vsr-server-status-zones
branch
from
47f727f
to
d4e21b7
Compare
|
@Dean-Coakley looks good. I suggest adding a StatusZone field to the config, rather than reusing the host value https://github.com/nginxinc/kubernetes-ingress/blob/master/internal/configs/version1/config.go#L64 Note that in the near future, with the support of StatusZones for location, we will be adding StatusZone field in the location struct as well. This way our StatusZone fields will be consistent. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
VirtualServer now sets a status_zone in the server block. Which allows metrics to be collected.
Metrics can be viewed at:
/api/5/http/server_zones/Checklist
Before creating a PR, run through this checklist and mark each as complete.