Add service subselector support in vs/vsr #712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dean-Coakley
added
the
enhancement
pleshakov
suggested changes
Sep 27, 2019
Dean-Coakley
force-pushed
the
support-service-subselector
branch
from
f9a1df8
to
b1f46df
Compare
Rulox
approved these changes
Oct 1, 2019
pleshakov
reviewed
Oct 1, 2019
There was a problem hiding this comment.
@Dean-Coakley good job! please see a suggestion related to the unit tests.
Dean-Coakley
force-pushed
the
support-service-subselector
branch
from
b790092
to
f50d601
Compare
bvighnesha
approved these changes
Oct 4, 2019
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Checklist
Before creating a PR, run through this checklist and mark each as complete.