-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable CRDs by default #779
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I could also leave manifests with - enable-custom-resources=false
commented out and make the flag default to true if that make more sense.
kubernetes-ingress/cmd/nginx-ingress/main.go
Lines 127 to 128 in de8d384
enableCustomResources = flag.Bool("enable-custom-resources", false, | |
"Enable custom resources") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Dean-Coakley thx. Please update the main.go https://github.com/nginxinc/kubernetes-ingress/blob/master/cmd/nginx-ingress/main.go#L127 and change the default value to true for the -enable-custom-resources
flag. Make sure to update CLI args docs as well. Also, this means you don't need to specify -enable-custom-resources
in the manifests because it will be true by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Proposed changes
CRDs were made GA in #772
CRDs should now be enabled by default in our provided manifests and helm chart.
Checklist
Before creating a PR, run through this checklist and mark each as complete.