Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix VSR updates when namespace is set implicitly #788

Merged
merged 2 commits into from
Dec 17, 2019
Merged

Fix VSR updates when namespace is set implicitly #788

merged 2 commits into from
Dec 17, 2019

Conversation

Dean-Coakley
Copy link
Contributor

Bug

  • When the namespace of the VirtualServerRoute is set implicitly. Updates to that resource are not applied.

Proposed changes

  • When the namespace of the VirtualServerRoute is set implicitly. The VirtualServerRoute will now use the namespace of the VirtualServer.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto master
  • I will ensure my PR is targeting the master branch and pulling from my branch from my own fork

@Dean-Coakley Dean-Coakley added the bug An issue reporting a potential bug label Dec 16, 2019
@Dean-Coakley Dean-Coakley self-assigned this Dec 16, 2019
@pleshakov pleshakov merged commit bc7f69d into master Dec 17, 2019
@pleshakov pleshakov deleted the fix-vsr-update branch December 17, 2019 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pleshakov pleshakov pleshakov approved these changes

@Rulox Rulox Rulox approved these changes

Assignees

@Dean-Coakley Dean-Coakley

Labels
bug An issue reporting a potential bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Dean-Coakley @pleshakov @Rulox