-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update examples to non-root nginx-hello #832
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @mohamed-gougam !
lgtm! including @tellet to review the test parts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry I didn't request it in my first review. Could you please revert the changes related to the test files only? I don't see any need in tests using the new image. Again sorry, I didn't bring that up earlier. Feel free to discuss it one again with the team.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please revert changes for backend1-svc.yaml
too. Apart from this everything is OK.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Proposed changes
This updates all the
.yaml
files using docker imagenginxdemos/hello
to use the new non-root imagenginxdemos/nginx-hello
. Container ports and target ports have been updated to match the image as well. These updates have also been applied for the tests to use the new image.Checklist
Before creating a PR, run through this checklist and mark each as complete.