-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend redirect URI validation with protocol check #850
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm pending the above change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Rulox thanks. a few notes about using $upstream_status instead of $status
docs-web/configuration/virtualserver-and-virtualserverroute-resources.md
Show resolved
Hide resolved
docs-web/configuration/virtualserver-and-virtualserverroute-resources.md
Show resolved
Hide resolved
docs-web/configuration/virtualserver-and-virtualserverroute-resources.md
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Rulox Thanks! The changes looks good!
Do we still support upstream_status in the error page redirect tho?
Not sure if this variable can be useful. The problem is that it could contain multiple values:
$upstream_status
keeps status code of the response obtained from the upstream server. Status codes of several responses are separated by commas and colons like addresses in the $upstream_addr variable. If a server cannot be selected, the variable keeps the 502 (Bad Gateway) status code.
Considering that, I don't think it could be useful in redirects.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Proposed changes
://
.