Add Dockerfile for NGINX Open Source for Openshift #894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pleshakov
reviewed
Mar 24, 2020
| && echo "module_hotfixes=true" >> /etc/yum.repos.d/nginx.repo \ | ||
| && yum update -y \ | ||
| && yum install -y nginx-${NGINX_VERSION} \ | ||
| && nginx \ |
There was a problem hiding this comment.
why nginx? 🤔 we're installing nginx-${NGINX_VERSION} in the previous line
There was a problem hiding this comment.
This is not installing, this is starting nginx binary for the first time. I followed the official docs for RHEL from here.
Dean-Coakley
approved these changes
Mar 24, 2020
|
I had to update the Dockerfiles with Labels so we can get the RH Certification for Openshift. Please have another look. cc @pleshakov @Dean-Coakley @lucacome Thanks |
|
Merging, labels can be updated if needed. |
pleshakov
added
the
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR adds a new Dockerfile for NGINX Ingress Controller for Openshift for NGINX open source.