Emit event for orphaned VirtualServerRoutes #995
Merged
+126
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rulox
suggested changes
Jun 18, 2020
pleshakov
suggested changes
Jun 19, 2020
LorcanMcVeigh
force-pushed
the
orphanedvsrs-emit-events
branch
from
b695b42
to
872ec42
Compare
pleshakov
suggested changes
Jun 22, 2020
pleshakov
suggested changes
Jun 23, 2020
Co-authored-by: Michael Pleshakov <pleshakov@users.noreply.github.com>
pleshakov
approved these changes
Jun 24, 2020
There was a problem hiding this comment.
@LorcanMcVeigh
looks good! 🚀
could you possibly update the PR name to be consistent with the names of the other PRs. For example, the commit message that you use - "Emit event to orphaned vsrs" - would work.
pleshakov
changed the title
pleshakov
added
the
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Vsr's are notified when they become orphaned by a vs, either by deleting the vs or through misconfiguration
Checklist
Before creating a PR, run through this checklist and mark each as complete.