Skip to content

chore: replace HOSTNAME with AWS_ROLE_SESSION_NAME, change now func and comment #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 20, 2023
Merged

chore: replace HOSTNAME with AWS_ROLE_SESSION_NAME, change now func and comment #26

merged 1 commit into from
May 20, 2023

Conversation

shawnhankim
Copy link
Contributor

@shawnhankim shawnhankim commented May 6, 2023 •
edited
Loading

Proposed changes

  • Remove a hardcoded default host name in NJS to be used for Role Session Name at multiple services in AWS
  • Change now function and comments
  • Remove unused comments such as x-amz-content-sha256 as this doesn't work for Lambda in the signature.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • I have updated any relevant documentation (README.md and CHANGELOG.md)

@shawnhankim shawnhankim requested a review from dekobon May 6, 2023 18:59
@shawnhankim shawnhankim self-assigned this May 6, 2023
@shawnhankim shawnhankim changed the title chore: add default host name var, change now func and comment chore: remove hardcoded default host name, change now func and comment May 13, 2023
@shawnhankim
Copy link
Contributor Author

Related issue: nginx/nginx-s3-gateway#126

dekobon
dekobon approved these changes May 16, 2023
View reviewed changes
Copy link
Collaborator

@dekobon dekobon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shawnhankim shawnhankim changed the title chore: remove hardcoded default host name, change now func and comment chore: replace HOSTNAME with AWS_ROLE_SESSION_NAME, change now func and comment May 20, 2023
@shawnhankim shawnhankim merged commit 21e82ca into nginxinc:main May 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dekobon dekobon dekobon approved these changes

Assignees

@shawnhankim shawnhankim

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shawnhankim @dekobon