Apply suggestions from code review

Co-authored-by: Saylor Berman <s.berman@f5.com>
nginxinc · May 15, 2024 · 3b07215 · 3b07215
1 parent dc4828e
commit 3b07215
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/apis/v1alpha1/nginxproxy_types.go b/apis/v1alpha1/nginxproxy_types.go
@@ -36,7 +36,7 @@ type NginxProxySpec struct {
 	// Default is false, meaning http2 will be enabled for all servers.
 	//
 	// +optional
-	DisableHTTP2 bool `json:"disableHTTP2"`
+	DisableHTTP2 bool `json:"disableHTTP2,omitempty"`
 }
 
 // Telemetry specifies the OpenTelemetry configuration.

diff --git a/internal/mode/static/nginx/config/base_http_config_template.go b/internal/mode/static/nginx/config/base_http_config_template.go
@@ -1,5 +1,5 @@
 package config
 
 const baseHTTPTemplateText = `
-{{- if .HTTP2 }}http2 on;{{- end }}
+{{- if .HTTP2 }}http2 on;{{ end }}
 `
diff --git a/internal/mode/static/state/dataplane/types.go b/internal/mode/static/state/dataplane/types.go
@@ -282,8 +282,8 @@ type SpanAttribute struct {
 	Value string
 }
 
-// BaseHTTPConfig holds the configuration options at the http context
+// BaseHTTPConfig holds the configuration options at the http context.
 type BaseHTTPConfig struct {
-	// HTTP2 specifies whether http2 should be enabled or disabled for all servers
+	// HTTP2 specifies whether http2 should be enabled or disabled for all servers.
 	HTTP2 bool
 }