-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename NGINX Kubernetes Gateway #1070
Conversation
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
17d34b7
to
816b800
Compare
5c3e7ba
to
c5e16d8
Compare
Some instances of NGINX Gateway that need to be changed: https://github.com/nginxinc/nginx-kubernetes-gateway/blob/main/docs/cli-help.md#static-mode (in the description for gatewayclass) |
c5e16d8
to
d73377c
Compare
Is this a place that should be updated too? "NGINX Gateway" -> "NGINX Gateway Fabric" |
d73377c
to
d4440cd
Compare
There are a few more instances of using NGINX Gateway in comments here (5 instances): |
Is this something that should be changed also? "nginx gateway Pod" If so, this would need to be changed too |
d4440cd
to
af899e1
Compare
Ty for catching. I forgot I added some references:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looked through each file, hopefully if we missed something we'll catch it later!
Renaming NGINX Kubernetes Gateway to NGINX Gateway Fabric. NKG is renamed to NGF
ced9583
to
f72ef91
Compare
Renaming NGINX Kubernetes Gateway to NGINX Gateway Fabric. NKG is renamed to NGF