-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add event processing histogram metric #1134
Merged
kate-osborn
merged 5 commits into
nginxinc:main
from
kate-osborn:feat/batch-processing-metrics
Oct 12, 2023
Merged
Add event processing histogram metric #1134
kate-osborn
merged 5 commits into
nginxinc:main
from
kate-osborn:feat/batch-processing-metrics
Oct 12, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
Improvements or additions to documentation
enhancement
New feature or request
labels
Oct 11, 2023
kate-osborn
commented
Oct 11, 2023
ciarams87
approved these changes
Oct 12, 2023
sjberman
reviewed
Oct 12, 2023
pleshakov
reviewed
Oct 12, 2023
sjberman
approved these changes
Oct 12, 2023
kate-osborn
force-pushed
the
feat/batch-processing-metrics
branch
2 times, most recently
from
October 12, 2023 17:51
8ee4af2
to
2f8d042
Compare
kate-osborn
force-pushed
the
feat/batch-processing-metrics
branch
from
October 12, 2023 17:58
2f8d042
to
6288b83
Compare
bjee19
approved these changes
Oct 12, 2023
pleshakov
approved these changes
Oct 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Problem: NGF does not measure how long it takes to process an event batch.
Solution: Add a new histogram metric
event_batch_processing_milliseconds
, that measures the time it takes to process an event batch. Also adds a debug log statement with the same information so we can debug spikes in processing time.Testing: Tested that the new metric is exported and that no errors occur when metric collection is disabled.
Please focus on (optional): I added a new Prometheus collector that handles this new metric instead of adding this metric to the existing nginx runtime collector. I think it makes sense to keep this metric separate from the nginx runtime metrics in case we end up splitting the control and data planes.
Closes #1131
Checklist
Before creating a PR, run through this checklist and mark each as complete.