-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Telemetry collector structure with some collected resources #1497
Conversation
If there is anything glaringly wrong and/or things I've added that aren't on the right track, I'm all open for the feedback! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please see my comments.
I'd also include in this PoC some static data like this -- #1309 -- so that we can see how the design will incorporate temetry data that stays the same during the lifetime of the NGF process.
d400651
to
25b0904
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The design looks good to me! Just a couple nits and questions.
9d916f4
to
0eb49a0
Compare
internal/mode/static/telemetry/telemetryfakes/fake_configuration_getter.go
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please see my comments, suggestions and requests.
Note: I haven't reviewed collector_test.go -- need a bit more time for that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bjee19
I left a few requests/suggestions
Could you prioritize rebasing and resolving conflicts?
The Job code will be changed so there will be a need for a another review.
faa010e
to
16fe23d
Compare
62274e4
to
89c41d5
Compare
Proposed changes
Problem: We want to create a starting design to collect telemetry data.
Solution: Implemented design to collect multiple types of telemetry data: Cluster Node Count, Count of NGF Resources (Graph), Project and Version.
Testing: Added unit tests. Did some end to end testing where I deployed NGF alongside some resources and saw the correct data being logged.
(I tested with the telemetry report period changed to 2 minutes)
Closes #1306 #1312 #1309
Checklist
Before creating a PR, run through this checklist and mark each as complete.