-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Product Telemetry collection document #1614
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, though I made a number of suggestions about phrasing.
This comment was marked as off-topic.
This comment was marked as off-topic.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, excepts for a couple of nits
@sjberman would it make sense to add a connection to Telemetry service here https://github.com/nginxinc/nginx-gateway-fabric/blob/main/site/content/overview/gateway-architecture.md#the-nginx-gateway-fabric-pod ? I think we can just add it to a list so that we don't clutter the diagram. For example:
Below are additional connections not depicted on the diagram:
|
Problem: Users will want to understand how and why we collect product telemetry, as well as how to opt-out if desired. Solution: Add a document explaining these things.
Co-authored-by: Alan Dooley <github@adubhlaoi.ch>
c9fe755
to
2b3de20
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1614 +/- ##
============================================
- Coverage 100.00% 85.93% -14.07%
============================================
Files 1 87 +86
Lines 209 5511 +5302
Branches 52 52
============================================
+ Hits 209 4736 +4527
- Misses 0 723 +723
- Partials 0 52 +52 ☔ View full report in Codecov by Sentry. |
Problem: Users will want to understand how and why we collect product telemetry, as well as how to opt-out if desired. Solution: Add a document explaining these things.
Problem: Users will want to understand how and why we collect product telemetry, as well as how to opt-out if desired.
Solution: Add a document explaining these things.
Closes #1319
Checklist
Before creating a PR, run through this checklist and mark each as complete.
Release notes
If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.