Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix namespace for longevity cronjob #1691

Merged
merged 1 commit into from
Mar 14, 2024
Merged

Conversation

sjberman
Copy link
Contributor

Problem: The longevity test cronjob was attempting to patch the wrong namespace, resulting in a failure.

Solution: Update the namespace. Also updated the VM version away from a deprecated version.

Testing: Verified that the cronjob works now

Closes #1690

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.

NONE

Problem: The longevity test cronjob was attempting to patch the wrong namespace, resulting in a failure.

Solution: Update the namespace.
@sjberman sjberman requested a review from a team as a code owner March 14, 2024 15:21
@github-actions github-actions bot added the tests Pull requests that update tests label Mar 14, 2024
@sjberman sjberman merged commit ef6fff3 into nginxinc:main Mar 14, 2024
40 checks passed
@sjberman sjberman deleted the tests/longevity branch March 14, 2024 16:29
amimimor pushed a commit to amimimor/nginx-gateway-fabric that referenced this pull request Apr 3, 2024
Problem: The longevity test cronjob was attempting to patch the wrong namespace, resulting in a failure.

Solution: Update the namespace.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Pull requests that update tests
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Longevity test cronjobs fail to re-rollout backend eployments
3 participants