Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ObservabilityPolicy CRD #1848

Merged
merged 3 commits into from
Apr 19, 2024

Conversation

sjberman
Copy link
Contributor

Problem: Users want to be able to configure observability settings for their HTTPRoutes, such as tracing.

Solution: Add the ObservabilityPolicy CRD, which is a direct policy that will attach to HTTPRoutes to configure these settings. Note: this pR contains the CRD only. A subsequent PR will add the implementation.

Also removed some regex restrictions in the NginxProxy CRD.

Testing: Verified that the CRD is created and validation works.

Please focus on (optional): We may need to update the regex as we implement and find out that certain values don't work.

Closes #1826

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.

NONE

@sjberman sjberman requested a review from a team as a code owner April 17, 2024 20:11
@github-actions github-actions bot added the enhancement New feature or request label Apr 17, 2024
@sjberman sjberman requested a review from a team as a code owner April 19, 2024 15:58
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Apr 19, 2024
Problem: Users want to be able to configure observability settings for their HTTPRoutes, such as tracing.

Solution: Add the ObservabilityPolicy CRD, which is a direct policy that will attach to HTTPRoutes to configure these settings. Note: this pR contains the CRD only. A subsequent PR will add the implementation.

Also removed some regex restrictions in the NginxProxy CRD.
@sjberman sjberman force-pushed the enh/observability-policy-crd branch from 9c2f8d9 to 62684f3 Compare April 19, 2024 17:26
@sjberman sjberman merged commit 62caed0 into nginxinc:main Apr 19, 2024
40 checks passed
@sjberman sjberman deleted the enh/observability-policy-crd branch April 19, 2024 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Add API for ObservabilityPolicy
3 participants