Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update minimum k8s version to 1.25 #1885

Merged
merged 3 commits into from
Apr 26, 2024
Merged

Update minimum k8s version to 1.25 #1885

merged 3 commits into from
Apr 26, 2024

Conversation

lucacome
Copy link
Member

@lucacome lucacome commented Apr 25, 2024 •
edited
Loading

Proposed changes

Bump the minimum version to 1.25 and remove all references to older versions and the webhook.

Closes #1868

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.

The minimum supported version of Kubernetes is now 1.25

@github-actions github-actions bot added documentation Improvements or additions to documentation chore Pull requests for routine tasks helm-chart Relates to helm chart labels Apr 25, 2024
@lucacome lucacome marked this pull request as ready for review April 25, 2024 23:57
@lucacome lucacome requested review from a team as code owners April 25, 2024 23:57
ciarams87
ciarams87 approved these changes Apr 26, 2024
View reviewed changes
Copy link
Member

@ciarams87 ciarams87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😎

@lucacome lucacome enabled auto-merge (squash) April 26, 2024 18:13
@lucacome lucacome merged commit b4b0772 into nginxinc:main Apr 26, 2024
40 checks passed
@lucacome lucacome deleted the chore/remove-webhook branch May 21, 2024 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kate-osborn kate-osborn kate-osborn approved these changes

@ciarams87 ciarams87 ciarams87 approved these changes

@sjberman sjberman sjberman approved these changes

Assignees
No one assigned
Labels
chore Pull requests for routine tasks documentation Improvements or additions to documentation helm-chart Relates to helm chart release-notes
Projects
NGINX Gateway Fabric
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update minimum k8s version to 1.25
4 participants
@lucacome @sjberman @ciarams87 @kate-osborn