Fix rbac ServiceAccount imagePullSecrets template #1953
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix rbac ServiceAccount imagePullSecrets template.
Problem: NGF fails to deploy with NGINX+ because of the rbac ServiceAccount imagePullSecrets template error.
Solution: Fix the spacing which moves imagePullSecrets from being in the ServiceAccount's
metadata
to its own field.Testing: Created Kubernetes secret and Docker Config Secret, then deployed NGF with NGINX+ and saw that the error was no longer there.
Closes #1952
Checklist
Before creating a PR, run through this checklist and mark each as complete.
Release notes
If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.