Add generate-all make target #2122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ciarams87
approved these changes
Jun 11, 2024
kate-osborn
approved these changes
Jun 11, 2024
Problem: We have a lot of generated files now and we might forget to run some targets. Soluton: Add generate-all target that calls all the other generate targets. Use this new target in the CI check and in the release PR to make sure everything is up to date.
lucacome
force-pushed
the
chore/add-generate-all
branch
from
279105a
to
10a70d9
Compare
github-actions
bot
added
the
documentation
ciarams87
approved these changes
Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Problem: We have a lot of generated files now and we might forget to run some targets.
Solution: Add generate-all target that calls all the other generate targets. Use this new target in the CI check and in the release PR to make sure everything is up to date.
Closes #2117
Checklist
Before creating a PR, run through this checklist and mark each as complete.
Release notes
If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.