Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Docker frontend and remove noisy summaries for tests #2182

Merged
merged 2 commits into from
Jul 1, 2024

Conversation

lucacome
Copy link
Member

@lucacome lucacome commented Jun 27, 2024

Proposed changes

Problem: Docker added summaries for the GitHub Action, but are very noisy and we don't need them for test images. There's also a new fronted that adds linting.

Solution: Remove the summaries for test builds and update Dockerfile with the new fronted. Fix warnings found.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.

NONE

@lucacome lucacome requested a review from a team as a code owner June 27, 2024 23:47
@github-actions github-actions bot added the chore Pull requests for routine tasks label Jun 27, 2024
@lucacome lucacome self-assigned this Jun 27, 2024
@lucacome lucacome enabled auto-merge (squash) July 1, 2024 19:46
@lucacome lucacome merged commit 0985999 into nginxinc:main Jul 1, 2024
36 of 37 checks passed
@lucacome lucacome deleted the chore/update-docker branch July 2, 2024 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants