Upload Plus Docker images to GAR #2192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: We want to be able to use NGINX Plus images built from edge and release branches in the NFR workflow Solution: Start pushing Plus images to GAR so they're available to other workflows
lucacome
force-pushed
the
chore/add-images-gar
branch
from
4d5d767
to
1e32b23
Compare
|
@lucacome Are we actually pushing images to ghcr.io? Or are they just cached images to the pipeline and then they disappear? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2192 +/- ##
=======================================
Coverage 87.59% 87.59%
=======================================
Files 96 96
Lines 6698 6698
Branches 50 50
=======================================
Hits 5867 5867
Misses 774 774
Partials 57 57 ☔ View full report in Codecov by Sentry. |
sjberman
approved these changes
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Problem: We want to be able to use NGINX Plus images built from
edgeand release branches in the NFR workflowSolution: Start pushing Plus images to GAR so they're available to other workflows
Closes #2143
Note: We're already pushing all the other images to ghcr.io for
edgeand release branchesChecklist
Before creating a PR, run through this checklist and mark each as complete.
Release notes
If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.