Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group otel and k8s.io updates #2200

Merged
merged 2 commits into from
Jul 5, 2024

Conversation

lucacome
Copy link
Member

@lucacome lucacome commented Jul 3, 2024

Proposed changes

Problem: Otel and k8s dependencies are often upgraded all at once and depend on one another

Solution: Instruct dependabot to group all the dependencies of the same set of libraries in a single PR

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.

NONE

Problem: Otel and k8s dependencies are often upgraded all at once and
depend on one another

Solution: Instruct dependabot to group all the dependencies of the same
set of libraries in a single PR
@lucacome lucacome self-assigned this Jul 3, 2024
@lucacome lucacome requested a review from a team as a code owner July 3, 2024 17:39
@github-actions github-actions bot added the chore Pull requests for routine tasks label Jul 3, 2024
@lucacome lucacome enabled auto-merge (squash) July 5, 2024 17:38
Copy link

codecov bot commented Jul 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.59%. Comparing base (a5507f7) to head (890ad41).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2200      +/-   ##
==========================================
+ Coverage   87.56%   87.59%   +0.02%     
==========================================
  Files          96       96              
  Lines        6698     6698              
  Branches       50       50              
==========================================
+ Hits         5865     5867       +2     
+ Misses        775      774       -1     
+ Partials       58       57       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lucacome lucacome merged commit a77cd75 into nginxinc:main Jul 5, 2024
37 checks passed
@lucacome lucacome deleted the chore/group-dependabot branch July 5, 2024 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants