Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ObservabilityPolicy TargetRefs documentation #2202

Merged
merged 1 commit into from
Jul 5, 2024

Conversation

pleshakov
Copy link
Contributor

Proposed changes

Problem:

  • The documentation for the targetRefs field of ObservabilityPolicy doesn't include GRPCRoute as supported kind.

Solution:

  • Fix that.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.

NONE

Problem:
- The documentation for the targetRefs field of ObservabilityPolicy
  doesn't include GRPCRoute as supported kind.

Solution:
- Fix that.
@pleshakov pleshakov requested review from a team as code owners July 3, 2024 22:40
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Jul 3, 2024
@pleshakov pleshakov merged commit a5507f7 into nginxinc:main Jul 5, 2024
37 checks passed
@pleshakov pleshakov deleted the doc/fix-description branch July 5, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants