Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow resource allocation #2216

Merged
merged 6 commits into from
Jul 15, 2024
Merged

Allow resource allocation #2216

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
98af08b
Add capability to add resource limits/requests
anwbtom Jul 10, 2024
80fc692
Update readme with new value
anwbtom Jul 10, 2024
6d156b9
Add empty values as default for gateway resources
anwbtom Jul 11, 2024
8fe094b
Woops remove local testcase values
anwbtom Jul 11, 2024
e42e16e
Ran make generate-helm-docs to hopefully fix the pipeline error
anwbtom Jul 12, 2024
81d33d9
Merge branch 'main' into feature/allow-resource-allocation
sjberman Jul 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions charts/nginx-gateway-fabric/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -290,6 +290,7 @@ The following table lists the configurable parameters of the NGINX Gateway Fabri
| `nginxGateway.readinessProbe.initialDelaySeconds` | The number of seconds after the Pod has started before the readiness probes are initiated. | int | `3` |
| `nginxGateway.readinessProbe.port` | Port in which the readiness endpoint is exposed. | int | `8081` |
| `nginxGateway.replicaCount` | The number of replicas of the NGINX Gateway Fabric Deployment. | int | `1` |
| `nginxGateway.resources` | The resource requests and/or limits of the nginx-gateway container. | object | `{}` |
| `nginxGateway.securityContext.allowPrivilegeEscalation` | Some environments may need this set to true in order for the control plane to successfully reload NGINX. | bool | `false` |
| `nodeSelector` | The nodeSelector of the NGINX Gateway Fabric pod. | object | `{}` |
| `service.annotations` | The annotations of the NGINX Gateway Fabric service. | object | `{}` |
Expand Down
4 changes: 4 additions & 0 deletions charts/nginx-gateway-fabric/templates/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,10 @@ spec:
lifecycle:
{{- toYaml .Values.nginxGateway.lifecycle | nindent 10 }}
{{- end }}
{{- if .Values.nginxGateway.resources }}
resources:
sjberman marked this conversation as resolved.
Show resolved Hide resolved
{{- toYaml .Values.nginxGateway.resources | nindent 10 }}
{{- end }}
ports:
{{- if .Values.metrics.enable }}
- name: metrics
Expand Down
3 changes: 3 additions & 0 deletions charts/nginx-gateway-fabric/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,9 @@ nginxGateway:
# -- The lifecycle of the nginx-gateway container.
lifecycle: {}

# -- The resource requests and/or limits of the nginx-gateway container.
resources: {}

# -- extraVolumeMounts are the additional volume mounts for the nginx-gateway container.
extraVolumeMounts: []

Expand Down
Loading