Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Truncate test result files #2255

Merged
merged 3 commits into from
Jul 18, 2024
Merged

Conversation

lucacome
Copy link
Member

Proposed changes

Problem: The NFR tests need to update the edge results, but they are appending the new results to the existing ones

Solution: Truncate existing results files so that the content is replaced and we see the diff in the PR

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.

NONE

Problem: The NFR tests need to update the edge results, but they are
appending the new results to the existing ones

Solution: Truncate existing results files so that the content is replaced
and we see the diff in the PR
@lucacome lucacome requested a review from a team as a code owner July 17, 2024 21:48
@github-actions github-actions bot added the chore Pull requests for routine tasks label Jul 17, 2024
Copy link

codecov bot commented Jul 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.76%. Comparing base (13c0163) to head (5285a0c).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2255      +/-   ##
==========================================
+ Coverage   87.73%   87.76%   +0.02%     
==========================================
  Files          96       96              
  Lines        6793     6793              
  Branches       50       50              
==========================================
+ Hits         5960     5962       +2     
+ Misses        775      774       -1     
+ Partials       58       57       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lucacome lucacome enabled auto-merge (squash) July 18, 2024 17:16
@lucacome lucacome merged commit 07b9d60 into nginxinc:main Jul 18, 2024
37 checks passed
@lucacome lucacome deleted the chore/test-files branch July 24, 2024 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants