Automate Zero Downtime Scale tests #2259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2259 +/- ##
=======================================
Coverage 87.76% 87.76%
=======================================
Files 96 96
Lines 6793 6793
Branches 50 50
=======================================
Hits 5962 5962
Misses 774 774
Partials 57 57 ☔ View full report in Codecov by Sentry. |
sjberman
force-pushed
the
tests/zero-downtime-scaling
branch
from
d75e499
to
f94f9a2
Compare
kate-osborn
reviewed
Jul 18, 2024
sjberman
force-pushed
the
tests/zero-downtime-scaling
branch
from
f94f9a2
to
bdc05b2
Compare
github-actions
bot
added
the
documentation
kate-osborn
reviewed
Jul 23, 2024
kate-osborn
reviewed
Jul 24, 2024
Problem: We want our NFR tests to be fully automated to save developer time for each release cycle, and have a repetitive way of running the tests. Solution: Automate the zero downtime scaling test. No longer collecting logs as done previously, because error logs would be unreliable to collect for pods that are scaling down (we don't have persistence that we can easily use in the automation to gather historic logs). Ultimately we are still ensuring that traffic is flowing and status updates occur, which are the important pieces here.
sjberman
force-pushed
the
tests/zero-downtime-scaling
branch
from
5f1bccc
to
6c4657e
Compare
github-actions
bot
added
the
documentation
kate-osborn
approved these changes
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: We want our NFR tests to be fully automated to save developer time for each release cycle, and have a repetitive way of running the tests.
Solution: Automate the zero downtime scaling test. No longer collecting logs as done previously, because error logs would be unreliable to collect for pods that are scaling down (we don't have persistence that we can easily use in the automation to gather historic logs). Ultimately we are still ensuring that traffic is flowing and status updates occur, which are the important pieces here.
Testing: Full NFR test run, as well as just these tests.
Closes #1435
Checklist
Before creating a PR, run through this checklist and mark each as complete.
Release notes
If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.