Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add oss suffix to OSS tests results #2261

Merged
merged 1 commit into from
Jul 19, 2024

Conversation

lucacome
Copy link
Member

Proposed changes

Problem: We want to be able to differentiate the OSS files when uploading the tests.

Solution: Add oss suffix to the files

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.

NONE

@lucacome lucacome requested a review from a team as a code owner July 18, 2024 22:36
@github-actions github-actions bot added documentation Improvements or additions to documentation chore Pull requests for routine tasks labels Jul 18, 2024
Copy link

codecov bot commented Jul 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.76%. Comparing base (4813408) to head (6abb546).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2261   +/-   ##
=======================================
  Coverage   87.76%   87.76%           
=======================================
  Files          96       96           
  Lines        6793     6793           
  Branches       50       50           
=======================================
  Hits         5962     5962           
  Misses        774      774           
  Partials       57       57           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lucacome lucacome enabled auto-merge (squash) July 18, 2024 22:44
Problem: We want to be able to differentiate the OSS files when
uploading the tests.

Solution: Add oss suffix to the files
@lucacome lucacome disabled auto-merge July 19, 2024 03:01
@lucacome lucacome merged commit 40784ac into nginxinc:main Jul 19, 2024
3 checks passed
@lucacome lucacome deleted the chore/change-name-oss branch July 19, 2024 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks documentation Improvements or additions to documentation
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants