Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automate Reconfiguration Performance Test #2313

Merged
merged 42 commits into from
Aug 12, 2024

Conversation

bjee19
Copy link
Contributor

@bjee19 bjee19 commented Jul 30, 2024

Proposed changes

Automate the reconfiguration performance test.

Problem: We want to automate our reconfiguration performance test so that we don't need to run it manually.

Solution: Automated the reconfiguration performance test.

Testing: Checked that results are reasonable.

Closes #1367

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.

NONE

@github-actions github-actions bot added documentation Improvements or additions to documentation tests Pull requests that update tests labels Jul 30, 2024
Copy link

codecov bot commented Jul 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.85%. Comparing base (31628c7) to head (683cd36).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2313   +/-   ##
=======================================
  Coverage   88.85%   88.85%           
=======================================
  Files         100      100           
  Lines        7513     7513           
  Branches       50       50           
=======================================
  Hits         6676     6676           
  Misses        781      781           
  Partials       56       56           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

tests/suite/reconfig_test.go Outdated Show resolved Hide resolved
tests/framework/queries.go Outdated Show resolved Hide resolved
tests/suite/reconfig_test.go Outdated Show resolved Hide resolved
tests/suite/reconfig_test.go Outdated Show resolved Hide resolved
tests/suite/reconfig_test.go Outdated Show resolved Hide resolved
tests/suite/reconfig_test.go Outdated Show resolved Hide resolved
tests/suite/reconfig_test.go Outdated Show resolved Hide resolved
tests/suite/reconfig_test.go Outdated Show resolved Hide resolved
tests/suite/reconfig_test.go Show resolved Hide resolved
tests/suite/reconfig_test.go Outdated Show resolved Hide resolved
tests/suite/reconfig_test.go Outdated Show resolved Hide resolved
tests/suite/reconfig_test.go Outdated Show resolved Hide resolved
tests/suite/reconfig_test.go Outdated Show resolved Hide resolved
tests/framework/queries.go Outdated Show resolved Hide resolved
tests/results/reconfig/v1.3.0/1.3.0-oss.md Outdated Show resolved Hide resolved
tests/suite/reconfig_test.go Outdated Show resolved Hide resolved
tests/suite/reconfig_test.go Outdated Show resolved Hide resolved
tests/suite/reconfig_test.go Outdated Show resolved Hide resolved
tests/suite/reconfig_test.go Outdated Show resolved Hide resolved
tests/suite/reconfig_test.go Show resolved Hide resolved
tests/suite/reconfig_test.go Outdated Show resolved Hide resolved
@bjee19 bjee19 force-pushed the tests/automate-reconfig-performance-tests branch from 4f9ac00 to 85734aa Compare August 1, 2024 19:56
@bjee19 bjee19 force-pushed the tests/automate-reconfig-performance-tests branch from fdf911c to e3c56be Compare August 8, 2024 19:11
@bjee19 bjee19 marked this pull request as ready for review August 8, 2024 20:54
@bjee19 bjee19 requested a review from a team as a code owner August 8, 2024 20:54
@bjee19 bjee19 force-pushed the tests/automate-reconfig-performance-tests branch from f66eb6c to 9069f04 Compare August 8, 2024 21:57
tests/framework/queries.go Outdated Show resolved Hide resolved
tests/suite/reconfig_test.go Outdated Show resolved Hide resolved
tests/suite/reconfig_test.go Show resolved Hide resolved
tests/suite/reconfig_test.go Outdated Show resolved Hide resolved
tests/suite/reconfig_test.go Outdated Show resolved Hide resolved
tests/framework/queries.go Outdated Show resolved Hide resolved
tests/framework/queries.go Outdated Show resolved Hide resolved
tests/suite/reconfig_test.go Outdated Show resolved Hide resolved
tests/suite/reconfig_test.go Outdated Show resolved Hide resolved
tests/suite/reconfig_test.go Outdated Show resolved Hide resolved
tests/suite/reconfig_test.go Show resolved Hide resolved
Copy link
Contributor

@sjberman sjberman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just be sure to delete the results file that was added.

Also be sure to do a full test run to make sure everything works. Nice job!

@sjberman
Copy link
Contributor

Actually on second thought, we can include the results file, just be sure we have one for both plus and oss. Or don't include either, and we'll get them both when we run the scheduled pipeline.

@bjee19 bjee19 force-pushed the tests/automate-reconfig-performance-tests branch from 3c06673 to 683cd36 Compare August 12, 2024 22:18
@bjee19 bjee19 merged commit e9b0a92 into nginxinc:main Aug 12, 2024
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation tests Pull requests that update tests
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Automate Reconfiguration Performance Test
4 participants