-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automate Reconfiguration Performance Test #2313
Automate Reconfiguration Performance Test #2313
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2313 +/- ##
=======================================
Coverage 88.85% 88.85%
=======================================
Files 100 100
Lines 7513 7513
Branches 50 50
=======================================
Hits 6676 6676
Misses 781 781
Partials 56 56 ☔ View full report in Codecov by Sentry. |
4f9ac00
to
85734aa
Compare
fdf911c
to
e3c56be
Compare
f66eb6c
to
9069f04
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just be sure to delete the results file that was added.
Also be sure to do a full test run to make sure everything works. Nice job!
Actually on second thought, we can include the results file, just be sure we have one for both plus and oss. Or don't include either, and we'll get them both when we run the scheduled pipeline. |
This reverts commit 0ee56f5.
3c06673
to
683cd36
Compare
Proposed changes
Automate the reconfiguration performance test.
Problem: We want to automate our reconfiguration performance test so that we don't need to run it manually.
Solution: Automated the reconfiguration performance test.
Testing: Checked that results are reasonable.
Closes #1367
Checklist
Before creating a PR, run through this checklist and mark each as complete.
Release notes
If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.