-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use /usr/bin/env for scripts #2315
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2315 +/- ##
=======================================
Coverage 87.76% 87.76%
=======================================
Files 96 96
Lines 6793 6793
Branches 50 50
=======================================
Hits 5962 5962
Misses 774 774
Partials 57 57 ☔ View full report in Codecov by Sentry. |
I'm assuming the results markdown files get their permissions from the code that generates them, so we'll probably need to update that as well. |
That was updated already with the recent changes to the NFR tests unless I missed something. It’s strange that the edge files still had wrong permissions but maybe it’s because they were created before and an append doesn’t change file permissions? |
Proposed changes
/usr/bin/env bash
is more flexible than/bin/bash
when using different OSes.Also found some files and script with wrong permissions.
Checklist
Before creating a PR, run through this checklist and mark each as complete.
Release notes
If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.