Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read Go build info from the binary #2319

Merged
merged 5 commits into from
Aug 1, 2024
Merged

Read Go build info from the binary #2319

merged 5 commits into from
Aug 1, 2024

Conversation

lucacome
Copy link
Member

Proposed changes

It wouldn't let me re-open #179

Problem: We're injecting information about the enviroment at build time. This could be unreliable and doesn't need to be done since go has all this info at build time already.

Solution: Get the info directly from the build.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.

NONE

@lucacome lucacome requested a review from a team as a code owner July 31, 2024 17:21
@github-actions github-actions bot added the chore Pull requests for routine tasks label Jul 31, 2024
Copy link

codecov bot commented Jul 31, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 87.74%. Comparing base (99a4532) to head (6e30f48).

Files Patch % Lines
cmd/gateway/commands.go 80.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2319      +/-   ##
==========================================
- Coverage   87.76%   87.74%   -0.03%     
==========================================
  Files          96       96              
  Lines        6793     6813      +20     
  Branches       50       50              
==========================================
+ Hits         5962     5978      +16     
- Misses        774      778       +4     
  Partials       57       57              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@salonichf5 salonichf5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

cmd/gateway/commands.go Show resolved Hide resolved
@lucacome lucacome merged commit 01c46ae into main Aug 1, 2024
36 of 37 checks passed
@lucacome lucacome deleted the chore/build-info branch August 1, 2024 17:29
@lucacome lucacome self-assigned this Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants