Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add high level doc for data plane config #2378

Merged
merged 4 commits into from
Aug 14, 2024

Conversation

sjberman
Copy link
Contributor

Problem: As a user, I want to know how I can configure global settings for nginx.

Solution: Add a doc that talks about how global data plane config can be set.

Closes #2246
Closes #2119

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.

NONE

@sjberman sjberman requested review from a team as code owners August 12, 2024 21:23
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Aug 12, 2024
Copy link

codecov bot commented Aug 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.83%. Comparing base (2ac3239) to head (c12fbb7).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2378      +/-   ##
==========================================
- Coverage   88.86%   88.83%   -0.03%     
==========================================
  Files         100      100              
  Lines        7515     7515              
  Branches       50       50              
==========================================
- Hits         6678     6676       -2     
- Misses        781      782       +1     
- Partials       56       57       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sjberman sjberman force-pushed the docs/data-plane-config branch 4 times, most recently from f03eee5 to bf92d4a Compare August 12, 2024 22:01
Copy link
Contributor

@ADubhlaoich ADubhlaoich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. A few suggestions, but norhing breaking.

site/content/how-to/data-plane-configuration.md Outdated Show resolved Hide resolved
site/content/how-to/data-plane-configuration.md Outdated Show resolved Hide resolved
Problem: As a user, I want to know how I can configure global settings for nginx.

Solution: Add a doc that talks about how global data plane config can be set.
@sjberman sjberman enabled auto-merge (squash) August 14, 2024 20:54
@sjberman sjberman merged commit b44b1a8 into nginxinc:main Aug 14, 2024
39 checks passed
@sjberman sjberman deleted the docs/data-plane-config branch August 14, 2024 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
Status: Done
5 participants