-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CRD versioning developer doc #2404
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
32c3d0b
to
f39a019
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2404 +/- ##
=======================================
Coverage 88.84% 88.84%
=======================================
Files 100 100
Lines 7527 7527
Branches 50 50
=======================================
Hits 6687 6687
Misses 784 784
Partials 56 56 ☔ View full report in Codecov by Sentry. |
Problem: We need a developer doc that explains how our CRDs are versioned and what constitutes a version change. Solution: Add a doc describing the criteria for this process.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few suggestions, otherwise LGTM.
Very clear.
7584a4e
to
cee5790
Compare
Problem: We need a developer doc that explains how our CRDs are versioned and what constitutes a version change.
Solution: Add a doc describing the criteria for this process.
Closes #936
Checklist
Before creating a PR, run through this checklist and mark each as complete.
Release notes
If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.