Add configurable data plane log level #2561
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Nginx error log level to NginxProxy.
Problem: Users would like to assign a log level for the data plane.
Solution: Add Nginx error log level to NginxProxy which allows users to set the error log level for Nginx.
Testing: Unit tests and manual testing.
Manual testing included
ErrorLevel
field in the NginxProxy resource.main.conf
file and runningnginx -T
) in the nginx container was updated correctly.info
log level.notice
such as theerror
level, after making changes which would result innotice
log levels being outputted (such as deleting and re-applying cafe.yaml in the cafe example), nonotice
log levels are outputted.nginx -T
correctly shows themain.conf
configuration file being included in the nginx configuration.Closes #901
Checklist
Before creating a PR, run through this checklist and mark each as complete.
Release notes
If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.