-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add controller to snippetsFilter status #2570
add controller to snippetsFilter status #2570
Conversation
2fe3af4
to
2dd2491
Compare
@salonichf5 did you manually test this? |
working on it :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM from a docs perspective but as the docs changes are minimal I will not give an approval in the context of the PR mostly being code.
d6a7c2c
to
033c246
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good @salonichf5
Just make sure to add the issue number to the pull request so it will be linked to the PR
LGTM! Just make sure to follow Kate's comment and add the issue number to the PR. |
7a3725c
into
nginxinc:feature/snippets-filter
Add controller to snippetsFilter status Problem: Users want to ensure controller name is added when condition is added to SnippetsFilter. Solution: Modify the SnippetsFilterStatus to include controller name writing status.
Add controller to snippetsFilter status Problem: Users want to ensure controller name is added when condition is added to SnippetsFilter. Solution: Modify the SnippetsFilterStatus to include controller name writing status.
Add controller to snippetsFilter status Problem: Users want to ensure controller name is added when condition is added to SnippetsFilter. Solution: Modify the SnippetsFilterStatus to include controller name writing status.
Add controller to snippetsFilter status Problem: Users want to ensure controller name is added when condition is added to SnippetsFilter. Solution: Modify the SnippetsFilterStatus to include controller name writing status.
Add controller to snippetsFilter status Problem: Users want to ensure controller name is added when condition is added to SnippetsFilter. Solution: Modify the SnippetsFilterStatus to include controller name writing status.
Add controller to snippetsFilter status Problem: Users want to ensure controller name is added when condition is added to SnippetsFilter. Solution: Modify the SnippetsFilterStatus to include controller name writing status.
Proposed changes
Write a clear and concise description that helps reviewers understand the purpose and impact of your changes. Use the
following format:
Problem: Users want to ensure controller name is added when condition is added to SnippetsFilter.
Solution: Modify the
SnippetsFilterStatus
to include controller name writing status.Testing: Unit tests
Manual Testing with two installations of NGF using different controllers
Please focus on (optional): If you any specific areas where you would like reviewers to focus their attention or provide
specific feedback, add them here.
Closes #2542
Checklist
Before creating a PR, run through this checklist and mark each as complete.
Release notes
If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.