Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable more parallel tests #2572

Merged
merged 3 commits into from
Sep 18, 2024
Merged

Enable more parallel tests #2572

merged 3 commits into from
Sep 18, 2024

Conversation

lucacome
Copy link
Member

Proposed changes

More tests in parallel

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.

NONE

@lucacome lucacome requested a review from a team as a code owner September 17, 2024 19:22
@github-actions github-actions bot added chore Pull requests for routine tasks tests Pull requests that update tests labels Sep 17, 2024
Copy link

codecov bot commented Sep 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.29%. Comparing base (8e63917) to head (2b8f26a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2572   +/-   ##
=======================================
  Coverage   89.29%   89.29%           
=======================================
  Files         100      100           
  Lines        7633     7633           
  Branches       50       50           
=======================================
  Hits         6816     6816           
  Misses        761      761           
  Partials       56       56           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lucacome lucacome assigned lucacome and unassigned mpstefan Sep 17, 2024
Copy link
Contributor

@salonichf5 salonichf5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

I was wondering we could run into more data race conditions since some of these tests do use variables between tests.

We should be careful moving forward, what do you think ?

@lucacome
Copy link
Member Author

Yeah I think we should make the tests as much independent as possible so we can catch actual data race problems

@lucacome lucacome requested a review from a team September 17, 2024 22:40
@sindhushiv sindhushiv added this to the v1.5.0 milestone Sep 18, 2024
@lucacome lucacome enabled auto-merge (squash) September 18, 2024 16:38
@lucacome lucacome merged commit a9d073e into nginxinc:main Sep 18, 2024
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks tests Pull requests that update tests
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants