Fix unchecked type assertions #2580
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
chore
kate-osborn
requested changes
Sep 18, 2024
There was a problem hiding this comment.
We have a helper function that we use for type assertions: https://github.com/nginxinc/nginx-gateway-fabric/blob/9971881bf2a8afb746a0105e365ed71d4f8724df/internal/framework/helpers/helpers.go#L49C6-L49C20
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2580 +/- ##
==========================================
- Coverage 89.29% 89.19% -0.11%
==========================================
Files 100 100
Lines 7633 7643 +10
Branches 50 50
==========================================
+ Hits 6816 6817 +1
- Misses 761 769 +8
- Partials 56 57 +1 ☔ View full report in Codecov by Sentry. |
salonichf5
requested changes
Sep 19, 2024
Comment on lines
+94
to
+96
| u.logger.Error(ErrFailedAssert, "object is not a client.Object") | ||
| return |
Comment on lines
+204
to
+206
| ngxruntimeCollector, ok := ngxruntimeCollector.(prometheus.Collector) | ||
| if !ok { | ||
| return fmt.Errorf("ngxruntimeCollector is not a prometheus.Collector: %w", status.ErrFailedAssert) |
kate-osborn
reviewed
Sep 19, 2024
lucacome
force-pushed
the
chore/fix-assertion
branch
from
5cfb1d7
to
9445586
Compare
kate-osborn
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Fixes the remaining unchecked type assertions
Checklist
Before creating a PR, run through this checklist and mark each as complete.
Release notes
If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.