-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs-fix-broken-url #2585
docs-fix-broken-url #2585
Conversation
Hi @nginx-aoife! Thanks for opening this pull request! Please make sure to include the issue number in the PR description to automatically close the issue when the PR is merged. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2585 +/- ##
=======================================
Coverage 89.29% 89.29%
=======================================
Files 100 100
Lines 7633 7633
Branches 50 50
=======================================
Hits 6816 6816
Misses 761 761
Partials 56 56 ☔ View full report in Codecov by Sentry. |
Hi @nginx-aoife thanks for the PR! Can you please update the PR description to use the template, and format your commit message as: Problem: <> Thank you! |
Proposed changes
Fixing a broken URL in the Documentation. https://docs.nginx.com/nginx-gateway-fabric/installation/installing-ngf/helm/
Problem: The link
command-line flag
in the Nginx Gateway Fabric Docs in here https://docs.nginx.com/nginx-gateway-fabric/installation/installing-ngf/helm/#access-nginx-gateway-fabric is broken. User is returned a 404 page.Solution: I have updated the link to use the correct path
reference/cli-help.md#static-mode
Testing: Describe any testing that you did.
Please focus on (optional): If you any specific areas where you would like reviewers to focus their attention or provide
specific feedback, add them here.
Closes #ISSUE
Checklist
Before creating a PR, run through this checklist and mark each as complete.
Release notes
If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.