fix(chart-readme): Use correct indentation in lifecyce.preStop examples #2587
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Problem: The Helm chart example configuration for configuring
lifecycle.preStop
uses a misleading indentation that can confuse users.Solution: Updated the Helm chart's README by fixing the indentation of the example code block to showcase the proper JSON paths of
nginxGateway.lifecycle.preStop.exec.command
andnginx.lifecycle.preStop.exec.command
. ThePreStop
hook is described as havingexec
as a handler in https://kubernetes.io/docs/concepts/containers/container-lifecycle-hooks/#hook-handler-execution and https://kubernetes.io/docs/tasks/configure-pod-container/attach-handler-lifecycle-event/#define-poststart-and-prestop-handlers.Testing: Successfully deployed this chart into my cluster with the updated paths, but still trying to figure out how to confirm they are set.
Checklist
Release notes